Skip to content

Conversation

@vlbee
Copy link
Member

@vlbee vlbee commented Jan 6, 2026

What does this change?

Replaces #14994

Ensures the ArticleMetaApp component is used for all screenwidths when the rendering target is Apps. This ensures the Listen to Article button appears on tablet landscape views.

No designs exist for the app-specic meta buttons (Follow, Notifications, Listen to Article) to appear in the Left Column meta component. The solution agreed by the Apps Ex team was to continue serving the "until.leftcol" grid (vertical tablet view) on wider breakpoints on the Apps and just make the screen margins wider to accommodate

No change has been made to wide screen article body layouts where elements overflow into the left and right columns.

Layouts used for Apps based on DecideLayoutApps

  • StandardLayout - Changed.
  • ImmersiveLayout - Changed.
  • CommentLayout - Changed.
  • ShowcaseLayout - Changed.
  • InteractiveLayout - Changed.
  • FullPageInteractiveLayout - No change. Layout does not include meta component for either web or apps. No audio duration available for these either because text hard coded in the atom (limited use eg. Month's best books, documentaries)
  • LiveLayout - No change. L2A button does not render on galleries
  • GalleryLayout - No change. L2A button does not render on galleries
  • PictureLayout - No change. L2A button does not render on picture layouts

Why?

The screen on some tablets in landscape are wider than the previous leftCol breakpoint being used to serve app-specific elements, so DCAR was serving the web meta component on extra wide app devices, including the app installed on Chromebooks.

Screenshots

BEFORE & AFTER

Standard Layout before/after
image

Comment Layout before/after
image

Showcase Layout before/after
image
image

Immersive Layout before/after
image

Interactive Layout before/after
image
image
image
image

@vlbee vlbee force-pushed the vb/fix-wide-take2 branch from d4d20b5 to 3aa1612 Compare January 6, 2026 16:20
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

@vlbee vlbee force-pushed the vb/fix-wide-take2 branch from 3aa1612 to 26c6902 Compare January 7, 2026 10:52
@vlbee vlbee added run_chromatic Runs chromatic when label is applied fix Departmental tracking: fix labels Jan 7, 2026
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jan 7, 2026
@vlbee vlbee added the run_chromatic Runs chromatic when label is applied label Jan 7, 2026
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jan 7, 2026
@vlbee vlbee marked this pull request as ready for review January 7, 2026 13:16
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@SiAdcock
Copy link
Contributor

SiAdcock commented Jan 8, 2026

Thanks for this @vlbee, the implementation meets the brief. I do however feel a bit queasy about the grid in apps and on web diverging in this way. So this is me questioning a design / product decision rather than commenting on the code specifically.

One of the benefits of the DCAR web-apps unification is that it simplifies design decisions and engineering overhead. This change adds complexity, new surprises and potential edge cases in the future.

If there's a design case to be made for having a two-column – as opposed to three-column – layout on landscape tablet within the apps, the same case could, and arguably should, apply to web as well.

Is it fair to say that the only reason to do this is because we don't currently have a design that incorporates this new button into the left column meta? If so this fix feels heavy-handed, and I'd suggest design involvement could yield a more sustainable solution (a button in the leftcol meta, for instance).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Departmental tracking: fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants