-
Notifications
You must be signed in to change notification settings - Fork 30
Fix ArticleMeta for wide views in the app #15087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d4d20b5 to
3aa1612
Compare
3aa1612 to
26c6902
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
|
Thanks for this @vlbee, the implementation meets the brief. I do however feel a bit queasy about the grid in apps and on web diverging in this way. So this is me questioning a design / product decision rather than commenting on the code specifically. One of the benefits of the DCAR web-apps unification is that it simplifies design decisions and engineering overhead. This change adds complexity, new surprises and potential edge cases in the future. If there's a design case to be made for having a two-column – as opposed to three-column – layout on landscape tablet within the apps, the same case could, and arguably should, apply to web as well. Is it fair to say that the only reason to do this is because we don't currently have a design that incorporates this new button into the left column meta? If so this fix feels heavy-handed, and I'd suggest design involvement could yield a more sustainable solution (a button in the leftcol meta, for instance). |
What does this change?
Replaces #14994
Ensures the ArticleMetaApp component is used for all screenwidths when the rendering target is Apps. This ensures the Listen to Article button appears on tablet landscape views.
No designs exist for the app-specic meta buttons (Follow, Notifications, Listen to Article) to appear in the Left Column meta component. The solution agreed by the Apps Ex team was to continue serving the "until.leftcol" grid (vertical tablet view) on wider breakpoints on the Apps and just make the screen margins wider to accommodate
No change has been made to wide screen article body layouts where elements overflow into the left and right columns.
Layouts used for Apps based on
DecideLayoutAppsWhy?
The screen on some tablets in landscape are wider than the previous leftCol breakpoint being used to serve app-specific elements, so DCAR was serving the web meta component on extra wide app devices, including the app installed on Chromebooks.
Screenshots
BEFORE & AFTER
Standard Layout before/after

Comment Layout before/after

Showcase Layout before/after


Immersive Layout before/after

Interactive Layout before/after



