Merged
Conversation
PatrykPaluch
requested changes
Mar 31, 2026
| using Cosmobot.BuildingSystem; | ||
| using Cosmobot.ItemSystem; | ||
| using Cosmobot.Utils; | ||
| using NUnit.Framework; |
Acu1000
requested changes
Apr 1, 2026
| .CreateResourcePreview((SerializableDictionary<ItemInfo, int>)requiredResources, previewCount); | ||
| preview.transform.SetParent(transform); | ||
| preview.GetComponent<ResourcePreviewController>().SetRequirement(pair.Value); | ||
| preview.GetComponent<ResourcePreviewController>().SetRequirement(pair.Value, pair.Key.ModelPrefab); |
Collaborator
There was a problem hiding this comment.
Pass the ItemInfo (pair.Key) instead of passing the prefab itself - it'll allow the preview to have access to other information about the item for potential future use. It will also mean that the responsibility of getting the model is given to the preview object directly.
| public int ResourceRequirement => resourceRequirement; | ||
|
|
||
| public void SetRequirement(int requirement) | ||
| public void SetRequirement(int requirement, GameObject previewObject) |
Collaborator
There was a problem hiding this comment.
As mentioned above, this should take an ItemInfo, not a GameObject
…at/139/constructionsite-previews
PatrykPaluch
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #139