fix(#133): Fix item spawner & items#135
Merged
PatrykPaluch merged 4 commits intomainfrom Mar 24, 2026
Merged
Conversation
PatrykPaluch
requested changes
Mar 19, 2026
| Shader shader = itemInfo?.Icon == null | ||
| ? Shader.Find("Hidden/InternalErrorShader") | ||
| : Shader.Find("Universal Render Pipeline/Unlit"); | ||
| if (material) { |
Member
There was a problem hiding this comment.
reverse if to avoid nested code:
if (!material) return;
Comment on lines
+60
to
+65
| ItemComponent itemComponent = gameObject.AddComponent<ItemComponent>(); | ||
| itemComponent.Init(new ItemInstance(itemInfo, itemData)); | ||
| Destroy(this); | ||
| Destroy(GetComponent<MeshRenderer>()); | ||
| Destroy(GetComponent<MeshFilter>()); | ||
| transform.localScale = Vector3.one; |
Member
There was a problem hiding this comment.
this code should run in build too:
void OnEnable()
{
#if UNITY_EDITOR
ReInitImage();
#endif
if (Application.isPlaying)
{
// code
}
}
PatrykPaluch
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #133