feat(pipelines): add aws_partition to aws_oidc account environment template#40
Open
ZachGoldberg wants to merge 1 commit intomainfrom
Open
feat(pipelines): add aws_partition to aws_oidc account environment template#40ZachGoldberg wants to merge 1 commit intomainfrom
ZachGoldberg wants to merge 1 commit intomainfrom
Conversation
…late Passes the Partition boilerplate variable through to the new optional aws_partition HCL field so non-commercial partition installs (GovCloud, China) work correctly with the AWSRoleName feature.
ZachGoldberg
requested review from
Resonance1584,
odgrim,
oredavids and
yhakbar
as code owners
yhakbar
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aws_partition = "{{ .Partition }}"to theaws_oidcblock in the account environment boilerplate templateContext
Pipelines is gaining a new optional
aws_partitionfield on theaws_oidcblock. ThePartitionvariable was already wired into the ARN strings in this template; this change passes it through to the dedicated HCL field as well, ensuring correctness for GovCloud and China installs that use theAWSRoleNameworkflow parameter.