tests: use regex for ANSI escape code detection in has_ansi_escape_codes()#235
Open
adityamoolya wants to merge 1 commit intogruns:masterfrom
Open
tests: use regex for ANSI escape code detection in has_ansi_escape_codes()#235adityamoolya wants to merge 1 commit intogruns:masterfrom
adityamoolya wants to merge 1 commit intogruns:masterfrom
Conversation
… in test_icecream.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented the TODO in tests/test_icecream.py:41 by replacing the oversimplified ANSI escape detection helper with regex-based detection.
Previously has_ansi_escape_codes() only checked for the substring \x1b[, which could produce false positives because it did not validate a complete ANSI CSI escape sequence.
This PR replaces that logic with a precompiled regex that matches full CSI sequences:
_ANSI_CSI_RE = re.compile(r'\x1b[[0-9;]*[A-Za-z]')
Changes included:
Testing
All existing tests that depend on has_ansi_escape_codes() (test_coloring, test_non_ascii_characters_no_syntax_highlighting, test_no_color_* suite) continue to pass with no modifications.