fix: update MODULE.bazel.lock for protobuf v34.0.bcr.1#6456
Merged
johanbrandhorst merged 2 commits intorenovate/major-protobuf-monorepofrom Mar 10, 2026
Merged
fix: update MODULE.bazel.lock for protobuf v34.0.bcr.1#6456johanbrandhorst merged 2 commits intorenovate/major-protobuf-monorepofrom
johanbrandhorst merged 2 commits intorenovate/major-protobuf-monorepofrom
Conversation
1 task
Replace protobuf/33.5 entries with protobuf/34.0.bcr.1 entries and remove stale source.json entries that are no longer referenced. The BCR version 34.0.bcr.1 already contains an upstream patch (load.patch) that fixes the CcToolchainConfigInfo compatibility issue with Bazel 9.0.0, so no additional patching is needed. Co-authored-by: johanbrandhorst <6604151+johanbrandhorst@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update dependency protobuf to v34
fix: update MODULE.bazel.lock for protobuf v34.0.bcr.1
Mar 10, 2026
johanbrandhorst
approved these changes
Mar 10, 2026
johanbrandhorst
merged commit b6dfbe8
into
renovate/major-protobuf-monorepo
14 checks passed
johanbrandhorst
added a commit
that referenced
this pull request
Mar 10, 2026
* chore(deps): update dependency protobuf to v34 * fix: update MODULE.bazel.lock for protobuf v34.0.bcr.1 (#6456) * Initial plan * fix: update MODULE.bazel.lock for protobuf v34.0.bcr.1 Replace protobuf/33.5 entries with protobuf/34.0.bcr.1 entries and remove stale source.json entries that are no longer referenced. The BCR version 34.0.bcr.1 already contains an upstream patch (load.patch) that fixes the CcToolchainConfigInfo compatibility issue with Bazel 9.0.0, so no additional patching is needed. Co-authored-by: johanbrandhorst <6604151+johanbrandhorst@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: johanbrandhorst <6604151+johanbrandhorst@users.noreply.github.com> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: johanbrandhorst <6604151+johanbrandhorst@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI
bazeljob fails becauseMODULE.bazel.lockstill references protobuf v33.5 after the dependency was bumped to v34.0.bcr.1 inMODULE.bazel.Changes
MODULE.bazel.lock: Replaceprotobuf/33.5entries withprotobuf/34.0.bcr.1(SHA256 hashes verified against BCR); remove stalesource.jsonentries fornlohmann_json/3.6.1,rules_apple/4.1.0,rules_swift/3.1.2, andswift_argument_parser/1.3.1.2that are no longer referencedNotes
PR #6428 attempted the same fix but also added a
single_version_overridepatch to addressCcToolchainConfigInfonot being a global in Bazel 9.0.0 — this caused a "redeclared at top level" error because the BCR package34.0.bcr.1already ships with aload.patchapplying exactly that fix. No additional patching is needed here.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.