Refactor tests: replace MockWebServer with WireMockServer in NeworkModificationTest #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent MILLOT <[email protected]>
souissimai
approved these changes
Jan 14, 2026
Contributor
souissimai
left a comment
souissimai
left a comment
There was a problem hiding this comment.
Just a few small remarks: some Sonar issues can be resolved. Otherwise, it looks ok to me
Signed-off-by: Florent MILLOT <[email protected]>
Contributor
Author
I removed the first issue, for the other ones it was from the previous code |
SlimaneAmar
approved these changes
Jan 19, 2026
flomillot
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
For
NeworkModificationTest