consider domain names other than .local in lookup/browse#46
Open
florianorben wants to merge 1 commit intograndcat:masterfrom
Open
consider domain names other than .local in lookup/browse#46florianorben wants to merge 1 commit intograndcat:masterfrom
florianorben wants to merge 1 commit intograndcat:masterfrom
Conversation
grandcat
reviewed
Jan 18, 2019
Owner
grandcat
left a comment
grandcat
left a comment
There was a problem hiding this comment.
Thanks. Only a small comment. Otherwise, LGTM.
| Domain: domain, | ||
| serviceName: fmt.Sprintf("%s.%s.", trimDot(service), trimDot(domain)), | ||
| } | ||
| func (s *ServiceRecord) SetDomain(domain string) { |
Contributor
|
After 18 months, is anyone addressing the review comment? It is a fairly major bug in the library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37