feat(cloud): Wrapper clients provide better introspection to determine availability of client objects#1146
Merged
dazuma merged 1 commit intogoogleapis:mainfrom Jan 24, 2025
Merged
Conversation
aandreassa
approved these changes
Jan 24, 2025
| [Google Cloud Logging](https://cloud.google.com/logging/) service. | ||
|
|
||
| Debug logging also requires that the versioned clients for this service be | ||
| sufficently recent, released after about Dec 10, 2024. If logging is not |
Contributor
Author
There was a problem hiding this comment.
Whoa, thanks for catching that!
…e availability of client objects
2dc7521 to
b89b1de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the client object factory methods in wrapper clients just expect that the underlying GAPIC provides the correct classes, and will raise LoadErrors or NameErrors if used with an out-of-date GAPIC. In particular, the unit tests for wrappers will fail if the GAPIC is out of date. This causes problems when a new service is added to an API, and gets added to the GAPIC and wrapper simultaneously. The wrapper tests fail until the GAPIC is updated and released, and we also typically go through the extra step of updating the version requirement in the dependency. This is a recurring source of toil.
This PR improves the situation by:
This PR also updates the wrapper README with a clarification that debug logging also requires a recent GAPIC.