Skip to content

Conversation

@benbowler
Copy link
Collaborator

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Build files for bfdf16f have been deleted.

@tofumatt tofumatt changed the base branch from develop to main December 9, 2025 12:53
@tofumatt tofumatt changed the base branch from main to develop December 9, 2025 12:53
Copy link
Collaborator

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a release issue and the branches have already been split, this one needs to target main.

Looks like the branch was made from develop though, so it needs to be rebased on main or possibly a new PR from main needs to be made.

The code itself looks fine though 👍🏻

@benbowler benbowler force-pushed the enhancement/11549-follow-up-template-tweaks-1 branch from 94c2608 to 9f2ff8d Compare December 9, 2025 15:32
@benbowler benbowler changed the base branch from develop to main December 9, 2025 15:32
@benbowler benbowler force-pushed the enhancement/11549-follow-up-template-tweaks-1 branch from 9f2ff8d to bfdf16f Compare December 9, 2025 15:34
@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Storybook is ready:

@benbowler
Copy link
Collaborator Author

@tofumatt I managed to cherry-pick on top of main and force push the branch to get this on main as you need.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Size Change: 0 B

Total Size: 2.2 MB

ℹ️ View Unchanged
Filename Size
./dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.css 124 B
./dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.js 20 B
./dist/assets/blocks/reader-revenue-manager/block-editor-plugin/index.js 42.7 kB
./dist/assets/blocks/reader-revenue-manager/common/editor-styles.css 307 B
./dist/assets/blocks/reader-revenue-manager/common/editor-styles.js 20 B
./dist/assets/blocks/reader-revenue-manager/contribute-with-google/index.js 5.88 kB
./dist/assets/blocks/reader-revenue-manager/contribute-with-google/non-site-kit-user.js 5.07 kB
./dist/assets/blocks/reader-revenue-manager/subscribe-with-google/index.js 5.88 kB
./dist/assets/blocks/reader-revenue-manager/subscribe-with-google/non-site-kit-user.js 5.07 kB
./dist/assets/blocks/sign-in-with-google/editor-styles.css 84 B
./dist/assets/blocks/sign-in-with-google/editor-styles.js 20 B
./dist/assets/blocks/sign-in-with-google/index.js 18.6 kB
./dist/assets/css/googlesitekit-admin-css-********************.min.css 65.1 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.7 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.57 kB
./dist/assets/js/146-********************.js 963 B
./dist/assets/js/201-********************.js 2.85 kB
./dist/assets/js/314-********************.js 100 kB
./dist/assets/js/315-********************.js 3.08 kB
./dist/assets/js/379-********************.js 3.7 kB
./dist/assets/js/590-********************.js 1.89 kB
./dist/assets/js/640-********************.js 2.36 kB
./dist/assets/js/909-********************.js 1.01 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 475 B
./dist/assets/js/googlesitekit-activation-********************.js 24.5 kB
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 54.4 kB
./dist/assets/js/googlesitekit-adminbar-********************.js 34.6 kB
./dist/assets/js/googlesitekit-api-********************.js 7.88 kB
./dist/assets/js/googlesitekit-block-tracking-********************.js 5.49 kB
./dist/assets/js/googlesitekit-components-********************.js 5.81 kB
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.5 kB
./dist/assets/js/googlesitekit-data-********************.js 1.7 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 6.95 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 1.51 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js 17.4 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 7.1 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js 22.7 kB
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 61.6 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 1.77 kB
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 745 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 1.77 kB
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 1.69 kB
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 1.72 kB
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 1.79 kB
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 1.13 kB
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 1.77 kB
./dist/assets/js/googlesitekit-i18n-********************.js 6.16 kB
./dist/assets/js/googlesitekit-key-metrics-setup-********************.js 47.1 kB
./dist/assets/js/googlesitekit-main-dashboard-********************.js 134 kB
./dist/assets/js/googlesitekit-metric-selection-********************.js 53 kB
./dist/assets/js/googlesitekit-modules-ads-********************.js 48.4 kB
./dist/assets/js/googlesitekit-modules-adsense-********************.js 132 kB
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 190 kB
./dist/assets/js/googlesitekit-modules-********************.js 19.8 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 23.3 kB
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 43.7 kB
./dist/assets/js/googlesitekit-modules-search-console-********************.js 65 kB
./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 33.7 kB
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 30.2 kB
./dist/assets/js/googlesitekit-notifications-********************.js 61 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 230 B
./dist/assets/js/googlesitekit-settings-********************.js 125 kB
./dist/assets/js/googlesitekit-splash-********************.js 73.3 kB
./dist/assets/js/googlesitekit-user-input-********************.js 46.3 kB
./dist/assets/js/googlesitekit-vendor-********************.js 328 kB
./dist/assets/js/googlesitekit-widgets-********************.js 103 kB
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 60.6 kB
./dist/assets/js/runtime-********************.js 1.92 kB

compressed-size-action

@tofumatt tofumatt merged commit 2c34c92 into main Dec 10, 2025
22 checks passed
@tofumatt tofumatt deleted the enhancement/11549-follow-up-template-tweaks-1 branch December 10, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create email report base template

2 participants