feat: introduce dedicated transitive preset and more generally account for "required plugins" during resolving#2575
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2575 +/- ##
==========================================
+ Coverage 67.88% 68.00% +0.12%
==========================================
Files 173 173
Lines 13420 13393 -27
==========================================
- Hits 9110 9108 -2
+ Misses 3595 3574 -21
+ Partials 715 711 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| }, | ||
| want: []string{}, | ||
| }, | ||
| // |
There was a problem hiding this comment.
this kind of line has been used throughout this file to break up blocks of tests, otherwise I find they get very hard to read through especially when having IDEs fold them - in this case the first "block" is focused on one specific enricher, while the second "block" is using the new transitive preset
There was a problem hiding this comment.
ah I see - maybe add an comment to indicate this is a "separator" between the two types of tests.
| license/depsdev | ||
| --- | ||
|
|
||
| [TestResolve_Enrichers_Presets/transitive - 1] |
There was a problem hiding this comment.
note this is empty because none of the required plugins are enabled - ideally I'd like to have them here, but for now I've just added the "all presets" snapshot test since we just have the two plugins that require another plugin 🤷
| }, | ||
| want: []string{}, | ||
| }, | ||
| // |
There was a problem hiding this comment.
ah I see - maybe add an comment to indicate this is a "separator" between the two types of tests.
3 participants
Resolves #2537