fix(java/pomxml): don't require offline network#1674
Closed
G-Rath wants to merge 1 commit intogoogle:mainfrom
Closed
fix(java/pomxml): don't require offline network#1674G-Rath wants to merge 1 commit intogoogle:mainfrom
G-Rath wants to merge 1 commit intogoogle:mainfrom
Conversation
cuixq
approved these changes
Jan 16, 2026
Collaborator
|
Actually the internal service may need this |
cuixq
previously requested changes
Jan 16, 2026
Collaborator
cuixq
left a comment
cuixq
left a comment
There was a problem hiding this comment.
We need to refactor the internal service first to stop it relying on this offline capability and then we can remove it.
cuixq
approved these changes
Jan 30, 2026
Collaborator
|
The internal refactoring change has been submitted - just need to wait for it gets deployed. I will add the blocker to the copied CL. |
Collaborator
|
@G-Rath I will close this PR since the duplicate one has been submitted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extractor does not care about network access, so should not be declaring itself as requiring an offline network
Blocks google/osv-scanner#2466