Skip to content

Veles urls with credentials#1651

Closed
alessandro-Doyensec wants to merge 18 commits intogoogle:mainfrom
doyensec:veles-urls-with-credentials
Closed

Veles urls with credentials#1651
alessandro-Doyensec wants to merge 18 commits intogoogle:mainfrom
doyensec:veles-urls-with-credentials

Conversation

@alessandro-Doyensec
Copy link
Collaborator

This PR adds the logic for detecting URLs containing credentials.

Note

The newly introduced package github.com/google/osv-scalibr/veles/secrets/urlcreds/validators/httpauth implements logic to:

  1. Parse WWW-Authenticate headers containing server challenges
  2. Generate standards-compliant responses

See RFC 7616: HTTP Digest Access Authentication

@alessandro-Doyensec
Copy link
Collaborator Author

Hello @erikvarga , thanks for the review.

There are still some conversations left open that require your attention.

Apologies for the trouble, but due to the scope of the validator, there are a couple of nuances that need to be addressed.

@alessandro-Doyensec
Copy link
Collaborator Author

alessandro-Doyensec commented Jan 14, 2026

Hello @erikvarga, beside #1651 (comment) and the conflicts, this PR should be ready to merge.

Please let me know if you have any updates or if there is anything else me to address.

Copy link
Collaborator

@erikvarga erikvarga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to import it and see what the internal tests think

@alessandro-Doyensec
Copy link
Collaborator Author

Hello @erikvarga

I see this has been hanging for a while, do you need anything from my side?

@erikvarga
Copy link
Collaborator

Nothing to do from your side, it just took a while to get all the approvals for importing the library. If everything goes well this will be merged shortly.

copybara-service bot pushed a commit that referenced this pull request Feb 2, 2026
@erikvarga
Copy link
Collaborator

Merged in f9e7ab2

@erikvarga erikvarga closed this Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments