Actually provide timeout setting to GCB executor#1093
Open
wbxyz wants to merge 2 commits intogoogle:mainfrom
Open
Actually provide timeout setting to GCB executor#1093wbxyz wants to merge 2 commits intogoogle:mainfrom
wbxyz wants to merge 2 commits intogoogle:mainfrom
Conversation
msuozzo
reviewed
Feb 27, 2026
| // Make the Cloud Build "Build" request | ||
| gcbBuild := e.makeBuild(input.Target, plan) | ||
| if opts.Timeout > 0 { | ||
| gcbBuild.Timeout = fmt.Sprintf("%ds", int(opts.Timeout.Seconds())) |
Member
There was a problem hiding this comment.
okay so i think the better behavior would be to default to the max gcb time (which arguably gcb should be doing when, for worker pools, 60m isn't the max). then we could keep the timeout param client-side and focus on making sure that's handled appropriately (i.e. addressing any polling issues we're running into)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.