Skip to content

#3636 Makes Aggregator#process use walkInPlatformIndependentOrder#4115

Open
sub101 wants to merge 1 commit intogoogle:masterfrom
sub101:master
Open

#3636 Makes Aggregator#process use walkInPlatformIndependentOrder#4115
sub101 wants to merge 1 commit intogoogle:masterfrom
sub101:master

Conversation

@sub101
Copy link

@sub101 sub101 commented Oct 28, 2023

related issue #3636

Motivation:

  • At AggregateDepsTask cache miss due to inconsistent order #3636, we fix AggregateDepsTask cache miss due to inconsistent order by walkInPlatformIndependentOrder
  • ✅ But on Aggregator#process, it still uses walkTopDown. so I think it's good to replace Aggregator#walkTopDown to walkInPlatformIndependentOrder too for consistency on all platforms

Modification:

  • Replace Aggregator#walkTopDown to walkInPlatformIndependentOrder too for consistency
  • Add walkInPlatformIndependentOrder unit test

Result:

  • Now Aggregator#process works in consistent order on all platforms!

@google-cla
Copy link

google-cla bot commented Oct 28, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant