Add immutability as a string_view invariant and remove unsafe#621
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 6, 2026
Merged
Add immutability as a string_view invariant and remove unsafe#621copybara-service[bot] merged 1 commit intomainfrom
unsafe#621copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_879103684
branch
from
47afe10 to
954d705
Compare
Mutating data while it is pointed to by a `string_view` is prohibitively weird and nonstandard behavior in C++. APIs that traffic in `string_view` come with a standard expectation that the underlying data is immutable for the lifetime of the `string_view`. Therefore, we should not push meaningless `unsafe` to Rust users in order to justify a standard invariant. PiperOrigin-RevId: 879785327
copybara-service
bot
force-pushed
the
test_879103684
branch
from
954d705 to
a02a069
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add immutability as a string_view invariant and remove
unsafeMutating data while it is pointed to by a
string_viewisprohibitively weird and nonstandard behavior in C++. APIs that
traffic in
string_viewcome with a standard expectation that theunderlying data is immutable for the lifetime of the
string_view.Therefore, we should not push meaningless
unsafeto Rust users in orderto justify a standard invariant.