Skip to content

Swarming: Add missing v2 protos#5189

Merged
IvanBM18 merged 1 commit intomasterfrom
feature/swarming/add_v2_protos
Mar 6, 2026
Merged

Swarming: Add missing v2 protos#5189
IvanBM18 merged 1 commit intomasterfrom
feature/swarming/add_v2_protos

Conversation

@IvanBM18
Copy link
Collaborator

@IvanBM18 IvanBM18 commented Mar 4, 2026

In an effort to add the swarming changes gradually back again, we are starting by adding back the missing gRRPC protos, these files were auto generated by running

./src/clusterfuzz/_internal/protos/generate.sh

dev environment Test Proof:

This files have been present already in the dev branch since last monday:
Metrics seem consistent since last monday

No logs indicating a regression of the prod issue:
image

@IvanBM18 IvanBM18 requested a review from a team as a code owner March 4, 2026 17:50
@IvanBM18 IvanBM18 self-assigned this Mar 4, 2026
@IvanBM18 IvanBM18 added the swarming Changes related to the clusterfuzz-swarming integration label Mar 4, 2026
Copy link
Collaborator

@jardondiego jardondiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cemon721-a11y

This comment was marked as spam.

@cemon721-a11y

This comment was marked as spam.

@letitz
Copy link
Collaborator

letitz commented Mar 5, 2026

Thanks for checking in dev, though based on both symptoms and investigation, we have no reason to believe this is related to the prod issue we saw.

Copy link
Collaborator

@letitz letitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jardondiego jardondiego requested review from hunsche and javanlacerda and removed request for hunsche and javanlacerda March 5, 2026 14:46
@jardondiego
Copy link
Collaborator

jardondiego commented Mar 5, 2026

Should we re-open this pull request to target the dev branch instead? @javanlacerda @hunsche

Copy link
Contributor

@decoNR decoNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you provided dev evidence, thanks!

@IvanBM18 IvanBM18 merged commit 2f9f44f into master Mar 6, 2026
11 checks passed
@IvanBM18 IvanBM18 deleted the feature/swarming/add_v2_protos branch March 6, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

swarming Changes related to the clusterfuzz-swarming integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants