Fully migrate butler to gcloud storage #5121
Merged
+73
−149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully migrates all butler-related scripts to use
gcloud storage.Changes to
common.py:storagecommand._run_and_handle_exceptionto the previous state before the initial migration PR (4930), as that change was not well justified.The remaining scripts,
deploy.pyandcreate_config.py, were adapted to use the equivalentgsutilcommand ongcloud storage.Tests:
create_configis very difficult to test, as it depends on creating a whole new GCP project. IMO It's not worth the effort, as it is not critical to any workflow. Also, the migration guide states that these commands are essentially the same as in gsutil.b/436307629