-
Notifications
You must be signed in to change notification settings - Fork 595
Update Component ID Logic #5074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update Component ID Logic #5074
Conversation
|
/gcbrun |
|
|
||
| recovered_exception = None | ||
| try: | ||
| if issue_tracker.project == "google-buganizer": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonathanmetzman Do you see any issues with adding logs with this kind of data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the TL;DR here is some of our fuzzers are finding bugs and trying to assign them to buganizer components where ClusterFuzz does not have access. So, it silently fails to create bugs in the component's where developers are expecting them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javanlacerda Please take a look when you have a moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think the logging issue would be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonathanmetzman I think when I commented on this initially, I was concerned that ClusterFuzz instances will be logging potentially sensitive data in the form of buganizer components.
Upon further thought, only the owners of the instance will have access to these logs. So no, I don't think there is any issue with this, and it will help us to better assign issues to owners in our instance.
479ef6c to
5b68ab1
Compare
|
/gcbrun |
5b68ab1 to
1253c06
Compare
|
/gcbrun |
4f13515 to
e75acf8
Compare
e75acf8 to
619b4b0
Compare
|
/gcbrun |
619b4b0 to
f3d1814
Compare
Some issues are not getting filed into the desired component of their code owners. This component is provided as a metadata. The current change aims at emphasising this metadata component by removing the automatic component. Please refer to b/438511288 for additional details.
f3d1814 to
2be632c
Compare
Some issues are not getting filed into the desired component of their code owners. This component is provided as a metadata.
The current change aims at emphasising this metadata component by removing the automatic component.
Please refer to b/438511288 for additional details.