EarlGrey 1.x | UITextView notifications are not triggered when using replaceText#771
Open
Simon-Kaz wants to merge 2 commits intogoogle:masterfrom
Open
EarlGrey 1.x | UITextView notifications are not triggered when using replaceText#771Simon-Kaz wants to merge 2 commits intogoogle:masterfrom
Simon-Kaz wants to merge 2 commits intogoogle:masterfrom
Conversation
Simon-Kaz
commented
Nov 12, 2018
Simon-Kaz
commented
- Updated replaceText to trigger UITextView notifications
- added sample tests to exercise the changes
- added a character counter label for simple assertions in the UI Tests.
… tests to exercise the changes and a character counter label for simple assertions
tirodkar
reviewed
Nov 12, 2018
| @@ -1,13 +1,17 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <document type="com.apple.InterfaceBuilder3.CocoaTouch.XIB" version="3.0" toolsVersion="12121" systemVersion="16G29" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" colorMatched="NO"> | |||
| <document type="com.apple.InterfaceBuilder3.CocoaTouch.XIB" version="3.0" toolsVersion="14313.18" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" colorMatched="YES"> | |||
Contributor
There was a problem hiding this comment.
Can I ask which Xcode you used? Just want to confirm.
Contributor
|
LG Otherwise! Thanks for this @Simon-Kaz ! |
tirodkar
approved these changes
Nov 12, 2018
Contributor
|
@Simon-Kaz - would you mind sending this fix for EG 2 as well? |
Author
I'll definitely try! :) |
Author
|
Hi @tirodkar , I've added the fix for EG2 as well. I also pushed a small fix for an incorrect selector just now, should be all good now 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.