Adds untracking for state kGREYPendingViewsToDisappear in greyswizzled_viewDidAppear#750
Open
stevenreinisch wants to merge 1 commit intogoogle:masterfrom
Open
Adds untracking for state kGREYPendingViewsToDisappear in greyswizzled_viewDidAppear#750stevenreinisch wants to merge 1 commit intogoogle:masterfrom
stevenreinisch wants to merge 1 commit intogoogle:masterfrom
Conversation
…troller's viewDidAppear has been called. This is neccessary if the user triggers a transition between UIViewControllers e.g. in the context of a UIPageViewController. See this example for an explanation: We show a UIPageViewController with three UIViewControllers <VC1>, <VC2>, and <VC3>. This is the series of events: * <VC1>.viewWillAppear * <VC1>.viewDidAppear * <VC1>.view is shown to the user * User performs swipe left * <VC2>.viewWillAppear * <VC1>.viewWillDisappear * <VC2>.viewDidAppear * <VC1>.viewDidDisappear * <VC2>.view is shown to the user * User performs swipe left (This swipe does not go far enough to show <VC3>.view at the end of the swipe) * <VC3>.viewWillAppear * <VC2>.viewWillDisappear * <VC2>.viewWillAppear * <VC2>.viewDidAppear * <VC3>.viewWillDisappear * <VC3>.viewDidDisappear * <VC2>.view is shown to the user again Without this patch, EarlGrey waits for viewDidDisappear: call on <VC2> and app state does not become kGREYIdle. With this patch, at the call of <VC2>.viewDidAppear state kGREYPendingViewsToDisappear is untracked and app state becomes kGREYIdle.
Contributor
|
Is this seen in a Page View Controller only? Would be great if we added a test for this as well so we can reproduce this. |
Author
|
Can you give me hint, at which existing test I can look at to have a starting point? |
Contributor
|
Take a look at one of our view controller specific tests like the UITableView one. You can create a new xib with a Page View Controller and then add some tests that reproduce your issue. To do so,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds untracking for state kGREYPendingViewsToDisappear if a UIViewController's viewDidAppear has been called.
This is neccessary if the user triggers an incomplete transition between UIViewControllers e.g. in the context of a UIPageViewController. See this example for an explanation:
We show a UIPageViewController with three UIViewControllers VC1, VC2, and VC3.
This is the series of events:
Without this patch, EarlGrey waits for viewDidDisappear: call on VC2 and app state does not become kGREYIdle.
With this patch, at the call of VC2.viewDidAppear state kGREYPendingViewsToDisappear is untracked and app state becomes kGREYIdle.