Look for groups matching the test target name outside of the main group#708
Open
weibel wants to merge 7 commits intogoogle:masterfrom
weibel:master
Open
Look for groups matching the test target name outside of the main group#708weibel wants to merge 7 commits intogoogle:masterfrom weibel:master
weibel wants to merge 7 commits intogoogle:masterfrom
weibel:master
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
CLAs look good, thanks! |
Merge downstream changes
Contributor
|
Thanks for looking into this @weibel. Apologies for not getting to it faster. Can you add a simple test for it in our rspec as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our project we have an intricate group structure and at some point the group containing our specs moved into a subfolder in the hierarchy.
When we run pod install after adding EarlGrey it will fail with the error
After looking through the code the culprit seemed to be the way the target names and group names are matched in configure_earlgrey.rb in copy_swift_files. In
test_target_group = project_test_targets.find { |g| g.display_name == target.name }only the root groups are looked at, and it did not work for our project.To solve the problem we have added a new method which will recurse through the group hierarchy until it finds a matching group name.