Fix missing fields in assertion error (#639)

[artyom-razinov]

There are more fields in error in logs of failure handler than in inout error parameter.

Previous code replaces fields (so some are lost) with only kErrorDetailActionNameKey and kErrorDetailElementMatcherKey, new code only modifies kErrorDetailElementMatcherKey.

See issue: #639

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

[googlebot]

CLAs look good, thanks!

[tirodkar]

This looks great. It would be great if you could add this to grey_handleFailureOfAssertion as well. Thanks a lot!

[artyom-razinov]

Ok! 👌

[khandpur]

Hey @artyom-razinov, just checking if you still plan on working on this in future.

[tirodkar]

@artyom-razinov we could make any changes and add them to the cl as well to preserve your commit, you'd need to allow contributions to it from your side though.

[artyom-razinov]

@tirodkar

It would be great if you could add this to grey_handleFailureOfAssertion as well.

I've just added it. Sorry for the delay, in my company we planned to gradually get rid of our fork of EarlGrey, but it is not a high priority task.

We also have support of Russian keyboard, however the code is not ready to be pushed to EarlGrey, because it is not scalable for every other keyboard. Is there any progress on supporting different keyboard layouts already? (#31)

If not I'll make a PR maybe this month.

[tirodkar]

A PR for that would be great. You can use grey_replaceText() to type in different languages till then.