Conversation
wrenj
requested review from
dmandar,
jacobsimionato,
nan-yu and
zeroasterisk
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a C++ validation library for A2UI JSON payloads, including comprehensive checks for schema adherence, component integrity, topology, and recursion limits. The implementation is well-structured with good separation of concerns and is accompanied by a thorough set of unit tests. My review focuses on improving code clarity, maintainability, and performance in the C++ implementation, as well as a minor correction in the documentation. The core logic is sound, and the suggestions aim to refine the implementation.
|
|
||
| const std::string COMPONENTS = "components"; | ||
| const std::string ID = "id"; | ||
| const std::string COMPONENT_PROPERTIES = "componentProperties"; |
There was a problem hiding this comment.
While consolidating the validation logic into A2uiValidator, I noticed that the validation in #624 was actually based on an outdated spec. As seen in this commit, the schema has evolved, notably replacing componentProperties with component.
I've updated Python A2uiValidator to support both v0.8 and v0.9 specs. Would you mind updating the CPP version to align with the python validator: https://github.com/google/A2UI/blob/main/a2a_agents/python/a2ui_agent/src/a2ui/inference/schema/validator.py?
3 participants
No description provided.