refactor: use string for command line buffers#2412
Merged
joelim-work merged 1 commit intogokcehan:masterfrom Mar 4, 2026
Merged
refactor: use string for command line buffers#2412joelim-work merged 1 commit intogokcehan:masterfrom
string for command line buffers#2412joelim-work merged 1 commit intogokcehan:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the type of
ui.cmdAccLeft,ui.cmdAccRightandui.cmdYankBuffrom[]runetostring. Most of the code uses them as a string anyway, and now thatunisegis used to calculate string widths, there is little reason to continue using[]rune.