Fix: Set GitHub Workflow Token Permissions to Read-Only by Default#22776
Fix: Set GitHub Workflow Token Permissions to Read-Only by Default#22776intojhanurag wants to merge 5 commits intogoharbor:mainfrom
Conversation
…fault Signed-off-by: intojhanurag <[email protected]>
Signed-off-by: intojhanurag <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22776 +/- ##
===========================================
+ Coverage 45.36% 65.90% +20.53%
===========================================
Files 244 1074 +830
Lines 13333 116563 +103230
Branches 2719 2939 +220
===========================================
+ Hits 6049 76817 +70768
- Misses 6983 35488 +28505
- Partials 301 4258 +3957
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Hey @bupd, I have a confusion: |
job level will override the top level permissions - I guess its better to set only job level permissions (ie., remove the top level permission) |
Signed-off-by: intojhanurag <[email protected]>
f3b0f53 to
daf384a
Compare
Signed-off-by: intojhanurag <[email protected]>
|
Hey @bupd , I switched the permission from top level to job level in every file , PTAL :) |
|
@intojhanurag can you also do the check by doing a release on your fork, making sure the release and build package works as expected. |
bupd
left a comment
There was a problem hiding this comment.
/lgtm,
Thanks @intojhanurag for your contributions
Signed-off-by: intojhanurag <[email protected]>
|
Hey @bupd , All scanning related workflow has been passed . That one you can see failed , it is due to Aws credential :)
|

Thank you for contributing to Harbor!
Description
Set all affected workflows to use read-only GITHUB_TOKEN by default and scope elevated permissions only at job level where required.
Issue
Fixes #22760
Please indicate you've done the following: