Skip to content

fix(perm): allow for GETs when secrets are disabled#1406

Merged
ecrupper merged 4 commits intomainfrom
fix/disabled-secret-write-only
Mar 6, 2026
Merged

fix(perm): allow for GETs when secrets are disabled#1406
ecrupper merged 4 commits intomainfrom
fix/disabled-secret-write-only

Conversation

@ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Mar 5, 2026

A firm hand is not really necessary here for GETs. Platform admins could delete secrets if they want to. This change will let transitions be easier if secrets already exist.

@ecrupper ecrupper requested a review from a team as a code owner March 5, 2026 17:53
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 11.76471% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.25%. Comparing base (76b266c) to head (25ef95b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
router/middleware/perm/perm.go 11.76% 14 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1406      +/-   ##
==========================================
- Coverage   58.25%   58.25%   -0.01%     
==========================================
  Files         660      660              
  Lines       25285    25286       +1     
==========================================
  Hits        14730    14730              
- Misses       9868     9872       +4     
+ Partials      687      684       -3     
Files with missing lines Coverage Δ
router/middleware/perm/perm.go 59.07% <11.76%> (-0.19%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ecrupper ecrupper merged commit b63ff11 into main Mar 6, 2026
12 of 14 checks passed
@ecrupper ecrupper deleted the fix/disabled-secret-write-only branch March 6, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants