Skip to content

fix(revert): use commit status API only#1405

Merged
ecrupper merged 3 commits intomainfrom
revert/check-runs
Mar 5, 2026
Merged

fix(revert): use commit status API only#1405
ecrupper merged 3 commits intomainfrom
revert/check-runs

Conversation

@ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Mar 5, 2026

Unfortunately the details_url in the Checks API is not an override of the link that shows up in the PR conversation like target_url is for the Status API.

This added bit of a friction (clicking the check, then clicking the link in the check run page) is just a bit too much.

Pretty disappointing that the link is not overridable. If that ever changes, we know how to integrate it 😅

@ecrupper ecrupper requested a review from a team as a code owner March 5, 2026 16:08
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 15.38462% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.26%. Comparing base (cefcb53) to head (479d6a7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
api/step/plan.go 0.00% 5 Missing ⚠️
scm/github/status.go 50.00% 4 Missing ⚠️
api/build/cancel.go 0.00% 2 Missing ⚠️
api/build/compile_publish.go 0.00% 2 Missing ⚠️
api/build/plan.go 0.00% 2 Missing ⚠️
api/build/update.go 0.00% 2 Missing ⚠️
api/webhook/post.go 0.00% 2 Missing ⚠️
api/build/gatekeep.go 0.00% 1 Missing ⚠️
api/build/restart.go 0.00% 1 Missing ⚠️
api/step/update.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1405      +/-   ##
==========================================
- Coverage   58.29%   58.26%   -0.03%     
==========================================
  Files         663      661       -2     
  Lines       25595    25301     -294     
==========================================
- Hits        14920    14742     -178     
+ Misses       9960     9870      -90     
+ Partials      715      689      -26     
Files with missing lines Coverage Δ
api/build/gatekeep.go 0.00% <0.00%> (ø)
api/build/restart.go 0.00% <0.00%> (ø)
api/step/update.go 0.00% <0.00%> (ø)
api/build/cancel.go 0.00% <0.00%> (ø)
api/build/compile_publish.go 0.00% <0.00%> (ø)
api/build/plan.go 0.00% <0.00%> (ø)
api/build/update.go 0.00% <0.00%> (ø)
api/webhook/post.go 0.00% <0.00%> (ø)
scm/github/status.go 79.20% <50.00%> (+5.05%) ⬆️
api/step/plan.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very unfortunate :(

looks like you didn't revert the PlanStep function signature. i'm guessing that is not intentional?

@ecrupper ecrupper merged commit 3ebd7d0 into main Mar 5, 2026
12 of 15 checks passed
@ecrupper ecrupper deleted the revert/check-runs branch March 5, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants