fix(revert): use commit status API only#1405
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1405 +/- ##
==========================================
- Coverage 58.29% 58.26% -0.03%
==========================================
Files 663 661 -2
Lines 25595 25301 -294
==========================================
- Hits 14920 14742 -178
+ Misses 9960 9870 -90
+ Partials 715 689 -26
🚀 New features to boost your workflow:
|
wass3rw3rk
reviewed
Mar 5, 2026
Member
wass3rw3rk
left a comment
There was a problem hiding this comment.
very unfortunate :(
looks like you didn't revert the PlanStep function signature. i'm guessing that is not intentional?
wass3rw3rk
approved these changes
Mar 5, 2026
KellyMerrick
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately the
details_urlin the Checks API is not an override of the link that shows up in the PR conversation liketarget_urlis for the Status API.This added bit of a friction (clicking the check, then clicking the link in the check run page) is just a bit too much.
Pretty disappointing that the link is not overridable. If that ever changes, we know how to integrate it 😅