Open
Conversation
Some aspects of flatbuffers are really slow (like construction) and we weren't really using flatbuffers in the way that they were intended anyway. This is a complete rewrite of the PMTs using std::variants. The code is much simpler and the performance is better (and in some cases an order of magnitude better). The code now requires c++20 as well. Signed-off-by: John Sallay <[email protected]>
Signed-off-by: Josh Morman <[email protected]> Signed-off-by: John Sallay <[email protected]>
Signed-off-by: Josh Morman <[email protected]> Signed-off-by: John Sallay <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The format commands take a long time to compile. To work on gcc 11, we had to do some heroics. It involved nested lambda functions. Since GR4.0 needs a more recent compiler we can simplify the function significantly.