Skip to content

chore: update mark-ready-when-ready to v1.1.3#460

Closed
kenyonj wants to merge 6 commits intogithub-community-projects:mainfrom
kenyonj:update-mark-ready-when-ready
Closed

chore: update mark-ready-when-ready to v1.1.3#460
kenyonj wants to merge 6 commits intogithub-community-projects:mainfrom
kenyonj:update-mark-ready-when-ready

Conversation

@kenyonj
Copy link

@kenyonj kenyonj commented Mar 16, 2026

Changes

Updates kenyonj/mark-ready-when-ready to v1.1.3.

What's new

  • Permission validation: The action validates token permissions upfront and provides a clear, actionable error message if any are missing. Works with permissions set at either the workflow or job level.

Workflow changes

  • Updated pinned SHA to match the v1.1.3 release.

Copilot AI review requested due to automatic review settings March 16, 2026 14:04
@kenyonj kenyonj force-pushed the update-mark-ready-when-ready branch 2 times, most recently from 2dd4d06 to 4783887 Compare March 16, 2026 14:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Simplifies the “mark-ready-when-ready” GitHub Actions workflow by relying on the upstream action’s internal precondition checks, consolidating permissions, and updating the action pin.

Changes:

  • Removes the job-level if: gate and job-level permissions: block.
  • Moves required permissions to the workflow level.
  • Updates kenyonj/mark-ready-when-ready pin to v1.1.0 (commit 6208a1e...).

You can also share your feedback on Copilot code review. Take the survey.

@kenyonj kenyonj force-pushed the update-mark-ready-when-ready branch 2 times, most recently from 681c5e3 to 1de24c0 Compare March 16, 2026 14:09
@kenyonj kenyonj marked this pull request as draft March 16, 2026 14:10
@kenyonj kenyonj changed the title Simplify mark-ready-when-ready workflow chore: update mark-ready-when-ready to v1.1.0 Mar 16, 2026
@jmeridth jmeridth added the Mark Ready When Ready Automatically mark draft PR ready when checks pass label Mar 16, 2026
@kenyonj kenyonj closed this Mar 16, 2026
@kenyonj kenyonj reopened this Mar 16, 2026
@jmeridth jmeridth added Mark Ready When Ready Automatically mark draft PR ready when checks pass and removed Mark Ready When Ready Automatically mark draft PR ready when checks pass labels Mar 16, 2026
@kenyonj kenyonj force-pushed the update-mark-ready-when-ready branch from 1de24c0 to 38c01a8 Compare March 16, 2026 14:29
- Remove job-level if: conditional — the action now checks for the
  trigger label and draft status internally (v1.1.0)
- Remove job-level permissions block — move to workflow level
- Update pin to v1.1.0 (6208a1e)
- Remove redundant top-level contents: read (replaced by contents: write)
@kenyonj kenyonj force-pushed the update-mark-ready-when-ready branch from 38c01a8 to 05894d4 Compare March 16, 2026 14:31
@kenyonj kenyonj changed the title chore: update mark-ready-when-ready to v1.1.0 chore: update mark-ready-when-ready to v1.1.1 Mar 16, 2026
kenyonj added 3 commits March 16, 2026 11:03
Remove top-level permissions block that was restricting the
GITHUB_TOKEN. Job-level permissions are sufficient and avoid
conflicts with the top-level default.
Adds early permission validation with clear error messages when
the token is missing required permissions.
@kenyonj kenyonj changed the title chore: update mark-ready-when-ready to v1.1.1 chore: update mark-ready-when-ready to v1.1.2 Mar 16, 2026
@kenyonj kenyonj changed the title chore: update mark-ready-when-ready to v1.1.2 chore: update mark-ready-when-ready to v1.1.3 Mar 16, 2026
@jmeridth
Copy link
Collaborator

Handled by #463. Closing this one.

@jmeridth jmeridth closed this Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Mark Ready When Ready Automatically mark draft PR ready when checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants