ci: [StepSecurity] Apply security best practices#455
Conversation
Signed-off-by: StepSecurity Bot <[email protected]>
jmeridth
changed the title
Added persist-credentials option to checkout action. Signed-off-by: Jason Meridth <[email protected]>
Set persist-credentials to false for checkout action. Signed-off-by: Jason Meridth <[email protected]>
Signed-off-by: Jason Meridth <[email protected]>
Signed-off-by: Jason Meridth <[email protected]>
Signed-off-by: Jason Meridth <[email protected]>
Signed-off-by: Jason Meridth <[email protected]>
Signed-off-by: Jason Meridth <[email protected]>
|
Any reason not to add this to to our other workflows?
|
ran this locally: ``` brew install pre-commit pre-commit install pre-commit clean pre-commit run --all-files ``` Result: ``` Cleaned /Users/jmeridth/.cache/pre-commit. [INFO] Initializing environment for https://github.com/gitleaks/gitleaks. [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Installing environment for https://github.com/gitleaks/gitleaks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... Detect hardcoded secrets.................................................Passed fix end of files.........................................................Passed trim trailing whitespace.................................................Passed flake8...................................................................Passed isort....................................................................Passed pylint...................................................................Passed mypy.....................................................................Passed black....................................................................Passed ``` Signed-off-by: Jason Meridth <[email protected]>
any of them calling ospo-reusable-workflows don't need it. I'm going to add the step to those reusable workflows. mark-ready-when-ready hadn't merged yet. Will add now. UPDATE: maybe not, what is an easy way to add a new file to the PR from a forked repo? 🤔 Maintainers can edit, but can we add? |
|
Good call on handling the reusable workflows separately. For adding files to a forked PR - if "Allow edits from maintainers" is checked, you can just |
😄 That's how I've been making changes but when I push it creates a new branch on the repo, not update the fork. 🤷 I'll do follow-up PR |
3 participants
Summary
This pull request is created by StepSecurity at the request of @jmeridth. Please merge the Pull Request to incorporate the requested changes. Please tag @jmeridth on your message if you have any questions related to the PR.
Security Fixes
Pinned Dependencies
GitHub Action tags and Docker tags are mutable. This poses a security risk. GitHub's Security Hardening guide recommends pinning actions to full length commit.
Harden Runner
Harden-Runner is an open-source security agent for the GitHub-hosted runner to prevent software supply chain attacks. It prevents exfiltration of credentials, detects tampering of source code during build, and enables running jobs without
sudoaccess. See how popular open-source projects use Harden-Runner here.Harden runner usage
You can find link to view insights and policy recommendation in the build log
Please refer to documentation to find more details.
Detect Vulnerabilities with SAST Workflow
Static Code Analysis (also known as Source Code Analysis) is usually performed as part of a Code Review (also known as clear-box testing) and is carried out at the Implementation phase of a Security Development Lifecycle (SDL). Static Code Analysis commonly refers to the running of Static Code Analysis tools that attempt to highlight possible vulnerabilities within ‘static’ (non-running) source code by using techniques such as Taint Analysis and Data Flow Analysis.
Add Dependency Review Workflow
The Dependency Review Workflow enforces dependency reviews on your pull requests. The action scans for vulnerable versions of dependencies introduced by package version changes in pull requests, and warns you about the associated security vulnerabilities. This gives you better visibility of what's changing in a pull request, and helps prevent vulnerabilities being added to your repository.
Maintain Code Quality with Pre-Commit
Pre-commit is a framework for managing and maintaining multi-language pre-commit hooks. Hooks can be any scripts, code, or binaries that run at any stage of the git workflow. Pre-commit hooks are useful for enforcing code quality, code formatting, and detecting security vulnerabilities.
Feedback
For bug reports, feature requests, and general feedback; please email [email protected]. To create such PRs, please visit https://app.stepsecurity.io/securerepo.
Signed-off-by: StepSecurity Bot [email protected]