Open
Conversation
ginkgo-bot
added
type:solver
yhmtsai
requested changes
Mar 17, 2026
Member
yhmtsai
left a comment
yhmtsai
left a comment
There was a problem hiding this comment.
LGTM. mainly on the passing by value or reference on local_accessor
Comment on lines
+167
to
168
| } | ||
| #define GKO_BIND_SHFL(ShflOpName, ShflOp) \ |
Member
There was a problem hiding this comment.
Suggested change
| } | |
| #define GKO_BIND_SHFL(ShflOpName, ShflOp) \ | |
| } | |
| #define GKO_BIND_SHFL(ShflOpName, ShflOp) \ |
Comment on lines
+94
to
95
| ValueType* reduction_helper = &reduction_helper_array[0]; | ||
| auto reduction_helper_real = |
Member
There was a problem hiding this comment.
Suggested change
| ValueType* reduction_helper = &reduction_helper_array[0]; | |
| auto reduction_helper_real = | |
| ValueType* reduction_helper = &reduction_helper_array[0]; | |
| auto __restrict__ reduction_helper_real = |
Member
Author
|
@yhmtsai This doesn't work out of the box, since [=] captures by values and lambdas are const by default, i.e. captured variables are |
yhmtsai
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been bugging me for a long time - compiling the backend creates gigabytes of error messages. This fixes all the issues by replacing uninitialized_array uses with local_accessor directly (which is more idiomatic SYCL anyways) and translating to pointers directly if necessary.