Open
Conversation
ginkgo-bot
added
reg:build
6 tasks
Member
|
Doesn't |
yhmtsai
requested changes
Aug 25, 2025
Member
yhmtsai
left a comment
yhmtsai
left a comment
There was a problem hiding this comment.
just realize we already have matrix Identity, so no need for preconditioner::Identity
MarcelKoch
force-pushed
the
1912/0-identity-config
branch
from
a0d77bd to
02b84db
Compare
Member
|
Error: The following files need to be formatted: You can find a formatting patch under Artifacts here or run |
upsj
approved these changes
Sep 29, 2025
| Pgm, | ||
| Schwarz | ||
| Schwarz, | ||
| Identity |
Member
There was a problem hiding this comment.
Suggested change
| Identity | |
| Identity, |
I think C++ allows trailing commas, that makes the diffs nicer
yhmtsai
requested changes
Oct 9, 2025
| #include <ginkgo/core/config/config.hpp> | ||
| #include <ginkgo/core/matrix/identity.hpp> | ||
|
|
||
| #include "cmake-build-debug/_deps/googletest-src/googletest/include/gtest/gtest-typed-test.h" |
Member
There was a problem hiding this comment.
Suggested change
| #include "cmake-build-debug/_deps/googletest-src/googletest/include/gtest/gtest-typed-test.h" |
do you need this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows parsing an object of type
matrix::Identity. This is helpful for configuring the preconditioner benchmark with no preconditioner.