terminal: fix viewport pin during resize reflow#12300
Merged
Conversation
Maybe related to #12298? When Screen resize forwards the active cursor into PageList reflow, a history-pinned viewport can be remapped into the active area before the preserved-cursor grow step finishes. The old code kept treating that viewport as a history pin during the intermediate grow calls, which left too few rows beneath the pin and tripped the viewport integrity checks. Fix this by normalizing the viewport back to active as soon as reflow moves the pinned row into the active area. Add a Screen-level regression test that exercises the full resize path with bounded scrollback and wrapped rows, and document the setup so the unwrap and viewport transition are clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe related to #12298?
When Screen resize forwards the active cursor into PageList reflow, a history-pinned viewport can be remapped into the active area before the preserved-cursor grow step finishes. The old code kept treating that viewport as a history pin during the intermediate grow calls, which left too few rows beneath the pin and tripped the viewport integrity checks.
Fix this by normalizing the viewport back to active as soon as reflow moves the pinned row into the active area. Add a Screen-level regression test that exercises the full resize path with bounded scrollback and wrapped rows, and document the setup so the unwrap and viewport transition are clear.