libghostty: Remove all libc++ and libc++ ABI dependencies#12291
Merged
libghostty: Remove all libc++ and libc++ ABI dependencies#12291
Conversation
8f9c166 to
95fd854
Compare
6 tasks
95fd854 to
8210296
Compare
Contributor
Author
|
I actually found a way to do replacement character decoding more in concert with simdutf. Our invalid utf8 path is probably a lot faster now, but will verify with benchmarks soon! |
ea0c686 to
1985d03
Compare
72d489d to
1e270b2
Compare
This updates simdutf to my fork which has a SIMDUTF_NO_LIBCXX option that removes all libc++ and libc++ ABI dependencies. From there, the hand-written simd code we have has been updated to also no longer use any libc++ features. Part of this required removing utfcpp since it depended on libc++ (`<iterator>`). libghostty-vt now only depends on libc.
1e270b2 to
e51de8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates simdutf to my fork which has a SIMDUTF_NO_LIBCXX option that removes all libc++ and libc++ ABI dependencies. The plan is to open an upstream PR with this, but I want to verify it here first.
From there, the hand-written simd code we have has been updated to also no longer use any libc++ features. Part of this required removing utfcpp since it depended on libc++ (
<iterator>).libghostty-vt now only depends on libc.
Benchmark Results
HEADmedianmainmedianmainvalid-mixed-1g-seed1.bin9.245s9.111s1.5%slowermainremains slightly faster on fully valid inputmalformed-mixed-1g-seed1-rate0.005.bin9.251s12.705s37.3%fasterApproximate throughput from the medians:
HEAD110.8 MiB/s,main112.4 MiB/sHEAD110.7 MiB/s,main80.6 MiB/s