Conversation
**Summary** Add the python-icoextract package. It is required as a runtime dependency for faugus-launcher.
|
See comment on #8003 |
malfisya
left a comment
malfisya
left a comment
There was a problem hiding this comment.
As this is a dependency of #8003 . It is recommended to include this commit to that PR instead of separating it. But since this is your first time on Solus packages repository, I think we can make an exception.
Also please add MAINTAINERS.md file, so you can assume responsibilty for this package. Read aboout it here.
| @@ -0,0 +1,3 @@ | |||
| releases: | |||
| id: 111867 | |||
| type: pypi | |||
There was a problem hiding this comment.
This is an incorrect format. Please read the [docs]9https://help.getsol.us/docs/packaging/monitoring.yaml).
| release : 1 | ||
| source : | ||
| - https://files.pythonhosted.org/packages/source/i/icoextract/icoextract-0.2.0.tar.gz : e7b4770c9a927a48ecfccc4ecd35afe477c2565a71449f92a95bdc92a0d10043 | ||
| homepage : https://github.com/jake-stewart/icoextract |
There was a problem hiding this comment.
Wrong homepage. This is the correct one https://github.com/jlu5/icoextract.
|
Please don't "resolve" the review before you actually address it. The point of pull request is that the maintainer can set certain standard of the code in the repository. People submitting pull request must adhere to that standard and must be willing to go through a review process. Please keep that in mind. |
3 participants
Summary
Add the python-icoextract package.
It is required as a runtime dependency for faugus-launcher.
Test Plan
Built with solbuild. Installed locally and verified that it provides required modules for faugus-launcher.
Checklist