feat(issues): Display exact release in dropdown #104565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors the resolved in release dropdown to use compact select instead of the deprecated select async component. Pulls any exact release match to the top of the search results, this fixes a bug where if you had more than 100 releases that contained the same query it might not display the exact match.
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Comment on lines
340
to
345
| onSelected={(statusDetails: ResolvedStatusDetails) => | ||
| handleAnotherExistingReleaseResolution(statusDetails) | ||
| } | ||
| organization={organization} | ||
| projectSlug={projectSlug} | ||
| /> | ||
| )); |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Member
Author
There was a problem hiding this comment.
modal has OrganizationContext now
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| <Version version={release.version} anchor={false} />{' '} | ||
| {isVersionInfoSemver(release.versionInfo.version) | ||
| ? t('(semver)') | ||
| : t('(non-semver)')} |
Contributor
There was a problem hiding this comment.
Bug: Missing null check for versionInfo causes crash
The code accesses release.versionInfo.version directly without optional chaining, but uses release.versionInfo?.package with optional chaining on lines 35 and 44, indicating versionInfo may be undefined. Other parts of the codebase (e.g., useProjectReleaseVersionIsSemver.tsx) explicitly check for !data?.versionInfo before accessing .version. If versionInfo is undefined, isVersionInfoSemver(release.versionInfo.version) will throw a runtime error.
malwilley
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the resolved in release dropdown to use compact select instead of the deprecated select async component.
Pulls any exact release match to the top of the search results, this fixes a bug where if you had more than 100 releases that contained the same query it might not display the exact match.
Adds a link to open release details in a new tab.
before
after