storybook: correct sidebar links #104522
Merged
storybook: correct sidebar links #104522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes location.state from story handling and allows us to use nested routes
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
| import {useStoriesLoader} from './useStoriesLoader'; | ||
|
|
||
| export default function Stories() { | ||
| export function useStoryParams(): {storyCategory?: StoryCategory; storySlug?: string} { |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Fix URL pattern matching to support both customer domain and organization-scoped URL formats: - Update useStoryParams() regex to match /stories/ anywhere in path - Update isLandingPage() regex to match paths ending with /stories - Normalize hero button URLs with organization context Without these fixes, stories would not load in organization-scoped deployments.
- Remove duplicate 'stories' segment in ESLint error message URLs - Fix slug generation for root-level shared files to prevent leading slashes Addresses bot feedback in PR review.
ryan953
reviewed
Dec 9, 2025
| { | ||
| children: 'Get Started', | ||
| to: '/stories?name=app/styles/colors.mdx', | ||
| to: '/stories/foundations/colors', |
Member
There was a problem hiding this comment.
why are there no trailing / for story urls?
Member
Author
There was a problem hiding this comment.
The current stories don't use them either, so this isn't a breaking change. That said, I'll open a PR to add support for it separately so that this remains django compat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix story links so that they are compatible with the double URL structure