fix: Specify debug symbol upload files and folders #2485
Conversation
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. Bug Fixes 🐛
Build / dependencies / internal 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| paths += $" \"{xboxSentryPluginPath}\""; | ||
| AddPath(paths, Path.Combine(buildOutputDir, "GameAssembly.dll"), logger, required: true); | ||
| // Sentry native in build output | ||
| AddPath(paths, Path.Combine(buildOutputDir, $"{baseName}_Data", "Plugins", "x86_64", "sentry.dll"), logger); |
There was a problem hiding this comment.
32-bit Windows IL2CPP sentry.dll path hardcoded incorrectly
Low Severity
The code handles both BuildTarget.StandaloneWindows (32-bit) and BuildTarget.StandaloneWindows64 (64-bit) in the same case block, but the sentry.dll path at line 220 is hardcoded to x86_64. For 32-bit Windows IL2CPP builds, Unity places native plugins in the x86 folder instead. This causes the Sentry native DLL's debug symbols to not be found and therefore not uploaded for 32-bit builds.
Summary
With #2298 we introduced pointing sentry-cli to the output folder to recursively upload everything from there. This introduces the problem that the target folder could be anything (e.g., the project root, or the downloads folder), causing very long upload times, "invalid MachO file" warnings, and even upload errors.
Instead, we're going back to specifying which files and folders are supposed to be picked up for each platform.
Changes