feat: Replace time-based log debouncing with content-based event throttling #2479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ILogThrottler interface and ContentBasedThrottler implementation - Throttle only LogError and LogException events (not breadcrumbs/structured logs) - Use message + stacktrace fingerprinting to deduplicate repeated errors - Add configuration via Editor window (Enable Event Throttling checkbox + Dedupe Window) - Remove old TimeDebounceBase and related classes - Update integrations to use new throttler Closes #2004
Contributor
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2004
Problem Statement
The existing time-based log debouncing system throttles events purely based on time intervals per log type. This approach has limitations:
Proposal
Replace time-based debouncing with content-based event throttling that deduplicates based on the actual error content (message + stacktrace fingerprint). This ensures:
Implementation
The new throttling system has the following elements
ILogThrottlerinterface - Abstraction allowing custom throttling implementations via options.SetLogThrottler()ContentBasedThrottler- Default implementation using message + stacktrace fingerprinting with a configurable dedupe window (default: 1000ms)