fix(xcode): Avoid silent failure when JS bundle creation fails due to Sentry Xcode scripts#4690
Merged
krystofwoldrich merged 6 commits intomainfrom Apr 7, 2025
Merged
Conversation
added 2 commits
March 26, 2025 10:51
krystofwoldrich
requested review from
antonis and
lucas-zimerman
as code owners
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5a22220+dirty | 384.61 ms | 419.06 ms | 34.45 ms |
| 7bc4d75+dirty | 420.96 ms | 472.25 ms | 51.29 ms |
| e540498+dirty | 408.56 ms | 480.00 ms | 71.44 ms |
| 9de3d45+dirty | 496.47 ms | 532.26 ms | 35.79 ms |
| 9433f35+dirty | 265.50 ms | 336.08 ms | 70.58 ms |
| 686b3bc+dirty | 363.48 ms | 356.17 ms | -7.31 ms |
| 205982c+dirty | 383.94 ms | 424.98 ms | 41.04 ms |
| 8900e1a+dirty | 371.40 ms | 377.70 ms | 6.31 ms |
| 3aecc61+dirty | 375.18 ms | 442.58 ms | 67.40 ms |
| 800171e+dirty | 432.15 ms | 549.63 ms | 117.48 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 5a22220+dirty | 7.15 MiB | 8.21 MiB | 1.06 MiB |
| 7bc4d75+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| e540498+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 9de3d45+dirty | 7.15 MiB | 8.40 MiB | 1.24 MiB |
| 9433f35+dirty | 7.15 MiB | 8.08 MiB | 959.34 KiB |
| 686b3bc+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 205982c+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 8900e1a+dirty | 7.15 MiB | 8.03 MiB | 901.79 KiB |
| 3aecc61+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 800171e+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3261206+dirty | 1219.49 ms | 1224.10 ms | 4.61 ms |
| af2c0b0+dirty | 1201.83 ms | 1208.94 ms | 7.11 ms |
| e2b64fe+dirty | 1232.22 ms | 1255.20 ms | 22.98 ms |
| 86d6d2c+dirty | 1267.55 ms | 1286.21 ms | 18.66 ms |
| 1d86dd6+dirty | 1249.71 ms | 1279.16 ms | 29.45 ms |
| 4cc5c27+dirty | 1211.45 ms | 1214.60 ms | 3.16 ms |
| 416f465+dirty | 1221.56 ms | 1226.48 ms | 4.92 ms |
| 3aecc61+dirty | 1237.75 ms | 1237.42 ms | -0.33 ms |
| 07e58c9+dirty | 1226.02 ms | 1228.35 ms | 2.33 ms |
| 6e8584e+dirty | 1274.50 ms | 1296.82 ms | 22.32 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3261206+dirty | 2.63 MiB | 3.69 MiB | 1.06 MiB |
| af2c0b0+dirty | 2.63 MiB | 3.76 MiB | 1.13 MiB |
| e2b64fe+dirty | 2.36 MiB | 2.85 MiB | 495.80 KiB |
| 86d6d2c+dirty | 2.36 MiB | 2.82 MiB | 462.82 KiB |
| 1d86dd6+dirty | 2.36 MiB | 2.89 MiB | 535.43 KiB |
| 4cc5c27+dirty | 2.36 MiB | 3.04 MiB | 698.52 KiB |
| 416f465+dirty | 2.36 MiB | 3.11 MiB | 759.80 KiB |
| 3aecc61+dirty | 2.36 MiB | 3.12 MiB | 778.58 KiB |
| 07e58c9+dirty | 2.36 MiB | 3.10 MiB | 752.28 KiB |
| 6e8584e+dirty | 2.36 MiB | 2.88 MiB | 533.17 KiB |
Previous results on branch: kw-fix-silent-xcode-failure
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1feb14a+dirty | 1225.12 ms | 1224.04 ms | -1.08 ms |
| 568bef1+dirty | 1231.80 ms | 1235.29 ms | 3.50 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1feb14a+dirty | 2.63 MiB | 3.76 MiB | 1.13 MiB |
| 568bef1+dirty | 2.63 MiB | 3.76 MiB | 1.13 MiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3261206+dirty | 1223.00 ms | 1226.06 ms | 3.06 ms |
| af2c0b0+dirty | 1229.82 ms | 1231.41 ms | 1.59 ms |
| e2b64fe+dirty | 1285.78 ms | 1297.56 ms | 11.78 ms |
| 86d6d2c+dirty | 1291.62 ms | 1296.80 ms | 5.18 ms |
| 1d86dd6+dirty | 1289.25 ms | 1293.36 ms | 4.11 ms |
| 4cc5c27+dirty | 1220.43 ms | 1215.13 ms | -5.30 ms |
| 416f465+dirty | 1232.48 ms | 1233.26 ms | 0.78 ms |
| 3aecc61+dirty | 1240.27 ms | 1240.51 ms | 0.24 ms |
| 07e58c9+dirty | 1216.42 ms | 1210.60 ms | -5.82 ms |
| 6e8584e+dirty | 1271.71 ms | 1281.26 ms | 9.55 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3261206+dirty | 3.19 MiB | 4.25 MiB | 1.07 MiB |
| af2c0b0+dirty | 3.19 MiB | 4.33 MiB | 1.14 MiB |
| e2b64fe+dirty | 2.92 MiB | 3.41 MiB | 499.97 KiB |
| 86d6d2c+dirty | 2.92 MiB | 3.37 MiB | 464.31 KiB |
| 1d86dd6+dirty | 2.92 MiB | 3.44 MiB | 538.27 KiB |
| 4cc5c27+dirty | 2.92 MiB | 3.61 MiB | 705.47 KiB |
| 416f465+dirty | 2.92 MiB | 3.67 MiB | 772.44 KiB |
| 3aecc61+dirty | 2.92 MiB | 3.69 MiB | 789.88 KiB |
| 07e58c9+dirty | 2.92 MiB | 3.66 MiB | 756.65 KiB |
| 6e8584e+dirty | 2.92 MiB | 3.44 MiB | 536.52 KiB |
Previous results on branch: kw-fix-silent-xcode-failure
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1feb14a+dirty | 1215.35 ms | 1220.71 ms | 5.37 ms |
| 568bef1+dirty | 1246.33 ms | 1250.30 ms | 3.97 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 1feb14a+dirty | 3.19 MiB | 4.33 MiB | 1.14 MiB |
| 568bef1+dirty | 3.19 MiB | 4.33 MiB | 1.14 MiB |
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 457e29f | 398.10 ms | 421.39 ms | 23.29 ms |
| 60d62c2 | 412.64 ms | 406.33 ms | -6.30 ms |
| 5f03ae9 | 444.88 ms | 448.89 ms | 4.01 ms |
| a15d370 | 431.43 ms | 440.25 ms | 8.82 ms |
| ea85ff8 | 411.42 ms | 400.85 ms | -10.57 ms |
| f54118b | 441.24 ms | 431.92 ms | -9.32 ms |
| 7bc4d75 | 488.76 ms | 473.28 ms | -15.48 ms |
| 255d28b | 424.09 ms | 441.96 ms | 17.87 ms |
| ddc0552 | 472.92 ms | 460.66 ms | -12.26 ms |
| 86d6d2c+dirty | 332.90 ms | 352.45 ms | 19.55 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 457e29f | 17.73 MiB | 19.84 MiB | 2.10 MiB |
| 60d62c2 | 17.75 MiB | 20.13 MiB | 2.38 MiB |
| 5f03ae9 | 17.75 MiB | 20.11 MiB | 2.36 MiB |
| a15d370 | 17.75 MiB | 20.13 MiB | 2.38 MiB |
| ea85ff8 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| f54118b | 17.74 MiB | 20.08 MiB | 2.35 MiB |
| 7bc4d75 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| 255d28b | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| ddc0552 | 17.74 MiB | 20.09 MiB | 2.35 MiB |
| 86d6d2c+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
lucas-zimerman
approved these changes
Apr 3, 2025
Collaborator
lucas-zimerman
left a comment
lucas-zimerman
left a comment
There was a problem hiding this comment.
It would be great if apple replaced the error sign as warning on finished builds with errors haha.
Other than that, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: finishes with errors, which means the app might be missing the js bundle
After: build fails (and only if explicitly allowed to continue silently then it continues)