-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
test(fastify): Verify if upstream error is fixed and won't regress #18838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dev-packages/e2e-tests/test-applications/node-fastify-5/tests/errors.test.ts
Show resolved
Hide resolved
dev-packages/e2e-tests/test-applications/node-fastify-5/tests/errors.test.ts
Outdated
Show resolved
Hide resolved
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
dev-packages/e2e-tests/test-applications/node-fastify-5/src/app-handle-error-override.ts
Show resolved
Hide resolved
dev-packages/e2e-tests/test-applications/node-fastify-5/src/app-handle-error-override.ts
Show resolved
Hide resolved
dev-packages/e2e-tests/test-applications/node-fastify-5/tests/errors.test.ts
Outdated
Show resolved
Hide resolved
39698b0 to
958d9c0
Compare
nicohrubec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for updating
closes #18418
closes JS-1260
A test that verifies that the upstream issue got fixed.
There was also one tiny config for playwright which was missed, so the wrong application was running.