Skip to content

Conversation

@JPeer264
Copy link
Member

closes #18418
closes JS-1260

A test that verifies that the upstream issue got fixed.

There was also one tiny config for playwright which was missed, so the wrong application was running.

@JPeer264 JPeer264 requested review from isaacs and nicohrubec January 15, 2026 16:56
@linear
Copy link

linear bot commented Jan 15, 2026

@JPeer264 JPeer264 requested a review from nicohrubec January 16, 2026 09:49
@github-actions
Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,249 - 9,517 -3%
GET With Sentry 1,661 18% 1,769 -6%
GET With Sentry (error only) 5,918 64% 6,054 -2%
POST Baseline 1,177 - 1,195 -2%
POST With Sentry 566 48% 579 -2%
POST With Sentry (error only) 1,038 88% 1,068 -3%
MYSQL Baseline 3,256 - 3,359 -3%
MYSQL With Sentry 429 13% 450 -5%
MYSQL With Sentry (error only) 2,668 82% 2,718 -2%

View base workflow run

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@JPeer264 JPeer264 requested a review from nicohrubec January 19, 2026 08:47
Copy link
Member

@nicohrubec nicohrubec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for updating

@JPeer264 JPeer264 merged commit df0bff8 into develop Jan 19, 2026
35 checks passed
@JPeer264 JPeer264 deleted the jp/verify-fastify branch January 19, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fastify 5 integration: reply.statusCode  is always 200 in  shouldHandleError , making docs example unusable

3 participants