Open
Conversation
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Documentation 📚
Internal Changes 🔧Deps
Other
Other
🤖 This preview updates automatically when you update the PR. |
Contributor
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7705 +/- ##
=============================================
- Coverage 85.412% 85.149% -0.263%
=============================================
Files 487 487
Lines 29086 29158 +72
Branches 12592 12605 +13
=============================================
- Hits 24843 24828 -15
- Misses 4193 4278 +85
- Partials 50 52 +2
... and 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
- Parse org_id from DSN host (e.g. `o123.ingest.sentry.io` → `123`) - Add `strictTraceContinuation` and `orgId` options to Options - Add `effectiveOrgId` computed property (explicit orgId > DSN > nil) - Propagate `sentry-org_id` in Baggage and TraceContext - Add `shouldContinueTrace` to SentryPropagationContext implementing the decision matrix for trace continuation validation Spec: https://develop.sentry.dev/sdk/foundations/trace-propagation/#strict-trace-continuation
antonis
force-pushed
the
feat/strict-trace-continuation
branch
from
ff9122b to
bdc33d9
Compare
6 tasks
6 tasks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
antonis
requested review from
itaybre,
noahsmartin,
philipphofmann and
philprime
as code owners
Contributor
|
@antonis is this ready for review? |
Contributor
Author
|
Thank you for the ping @itaybre. Yes 😅 |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Implement Strict Trace Continuation.
org_idfrom DSN host (e.g.o123.ingest.sentry.io→"123")strictTraceContinuation(Bool) andorgId(String?) optionssentry-org_idin Baggage and TraceContextshouldContinueTrace(options:baggageOrgId:)implementing the decision matrix💡 Motivation and Context
Prevents cross-org trace continuation by validating org IDs in distributed traces.
Part of the Strict Trace Continuation initiative.
💚 How did you test it?
32 new unit tests covering DSN parsing, options resolution, decision matrix, baggage propagation, and trace context serialization.
📝 Checklist
sendDefaultPIIis enabled.