Skip to content

Fix Trino parameterized type mapping#7662

Open
shunki-fujita wants to merge 2 commits intogetredash:masterfrom
shunki-fujita:fix/trino-parameterized-type-mapping
Open

Fix Trino parameterized type mapping#7662
shunki-fujita wants to merge 2 commits intogetredash:masterfrom
shunki-fujita:fix/trino-parameterized-type-mapping

Conversation

@shunki-fujita
Copy link
Copy Markdown
Contributor

@shunki-fujita shunki-fujita commented Mar 12, 2026

What type of PR is this?

Close: #7661

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Trino columns with parameterized types such as timestamp(0), timestamp(3), decimal(10,2), varchar(255), etc. are not correctly mapped to Redash column types. This causes timestamp columns to be displayed as epoch milliseconds in the UI when the result set contains NULL values.

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

The type determination for lines containing null is performed correctly.
スクリーンショット 2026-03-13 115906

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@shunki-fujita shunki-fujita marked this pull request as ready for review March 12, 2026 05:51
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="tests/query_runner/test_trino.py">

<violation number="1" location="tests/query_runner/test_trino.py:114">
P2: Parameterized fractional decimal is incorrectly asserted as `integer`, codifying wrong type semantics.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@shunki-fujita shunki-fujita force-pushed the fix/trino-parameterized-type-mapping branch from e1db5c7 to 0719438 Compare March 12, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trino columns with parameterized types (e.g. timestamp(0)) are not mapped correctly, causing epoch display

1 participant