Open
Conversation
This is a follow-on change from getmoto#9884 to allow more deterministic behavior
Since now more of moto uses the PRNG, any resource allocation alters the PRNG state, specifically the sts assume_role call in the setup One can confirm this by adding a 2nd assume-role call and watching the instance id change again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #9884
Current behavior
produces:
New behavior
Because the
os.urandomcall for the KMS master key has been replaced with the PRNG-awarerandomsystem in moto, now the master key bytes are deterministic and the round-trip encrypt-decrypt is successful even across moto resets (and I also tested it acrossmoto_serverrestarts)One will spot a seemingly unrelated change to
tests/test_moto_api/seeder/test_seeder.pybut that is because now there are no moreos.urandomcalls, so thests assume-roleconsumes a PRNG call, which modifies the instance-id that was in that test