feat: use LazyLock for constructing union types#1423
Open
nuts-rice wants to merge 5 commits intogeoarrow:mainfrom
Open
feat: use LazyLock for constructing union types#1423nuts-rice wants to merge 5 commits intogeoarrow:mainfrom
nuts-rice wants to merge 5 commits intogeoarrow:mainfrom
Conversation
kylebarron
approved these changes
Feb 3, 2026
| } | ||
|
|
||
| fn mixed_data_type(coord_type: CoordType, dim: Dimension) -> DataType { | ||
| //idx calculated as (coord_type as usize) * 4 + (dim as usize) |
Member
There was a problem hiding this comment.
This comment is useless; it describes the same thing as the line of code below
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LazyLocksfor caching mixed union typesLazyLocksforGeometryTypemixed_data_typeis now indexed lookup atMIXED_UNION_TYPESGeometryType::data_type()is indexed lookup atGEOMETRY_UNION_TYPES