You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I copy-pasted the kind of structure I found in the other routes for the other triggers. Is this really all that's needed? Perhaps clearer error messages? Also, should we add triggers for the new "add/remove project manager" routes?
PS: I reorganized some unclear permission checks I noticed in users.js while I was at it, apologies for mixing unrelated things in my PRs.
@mboudet, in core/project.service.js, on lines 38, 91 and 124, the await filer.project_XXX_project(project, fid) functions seem to be calling the relevant bash scripts further down the line (via core/file.js, on line 58). In that case, the only project path that didn't have a trigger was PUT \project, so all I really had to do was add a call to filer.project_update_project in the edit_project function in core/project.service.js.
Did I correctly understand what the filer.project_XXX_project functions are doing? Should I add something to the bash scripts themselves now?
Oh, you're right, seems like the code was already there (and seems like abims already use it). Sorry for wasting your time on this..
For the PUT route, as far as I can see, it's only used when editing pending projects, so I don't think actually need the trigger.
Though, can you modify the 'update' function to path both the new project and the old one? So that we do not need to modify the quota if it did not change.
For the bash script, we need to check how we can make it work at genouest, so i'll add the scripts later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I copy-pasted the kind of structure I found in the other routes for the other triggers. Is this really all that's needed? Perhaps clearer error messages? Also, should we add triggers for the new "add/remove project manager" routes?
PS: I reorganized some unclear permission checks I noticed in
users.jswhile I was at it, apologies for mixing unrelated things in my PRs.