Automatically delete users account requests in stage "pending email approval". after X days #555#576
Open
BobLamarley wants to merge 3 commits intogenouest:masterfrom
Conversation
Member
|
Ok, we already use 'commandLineArgs' actually (well, Roscoff / IFB do at least), it just wasn't in the package.json file. I guess it's fine. |
mboudet
reviewed
Jan 14, 2025
Comment on lines
+67
to
+70
| console.log(`User with UID ${user.uid} deleted.`); | ||
|
|
||
| const userMessage = `Your account has been deleted due to inactivity for over ${DAYS_TO_DELETE} days. If this was an error, please contact support.`; | ||
| await notify([user.email], 'Account Deletion Notice', userMessage); |
Member
There was a problem hiding this comment.
I wouldn't send a mail to an user who did not validate their email address. If it's invalid, you want to avoid sending an email to it to avoid reducing your own email reputation with rejections.
In any case, it's less an 'inactivity' issue, and more 'you did not validate your mail'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Origin:
#555
What I’ve done:
Key Details:
This is a Node.js script rather than a Bash script, as it leverages
maisrvfunctions to send emails.To run the script, you’ll need to set the
NODE_CONFIG_DIRenvironment variable to point to the configuration directory:export NODE_CONFIG_DIR=path/to/configUsage: To run the script manually, use the following command:
Scheduling: You can also schedule this script using
cron. For example, to run it every minute: