fix: Additional tests optimization when running on github actions. #293
Conversation
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
…-computing/mellea into fix/286-tests-cleanup
mellea/backends/model_ids.py
Outdated
| hf_model_name="ibm-granite/granite-4.0-micro", | ||
| ollama_name="ibm/granite4:micro", | ||
| ollama_name="granite4:micro", | ||
| openai_name="granite4:micro", # setting this just for testing purposes. |
There was a problem hiding this comment.
Since this is user facing, I don't think we should set this for testing purposes. We should just explicitly refer to .ollama_name when instantiating the backend/session.
jakelorocco
left a comment
jakelorocco
left a comment
There was a problem hiding this comment.
I think my prior comment is also unaddressed: https://github.com/generative-computing/mellea/pull/293/changes#r2682421674
Looks good once these are changed.
| """Allows you to use `pytest docs` to run the examples.""" | ||
| """Allows you to use `pytest docs` to run the examples. | ||
| To run notebooks, use: uv run --with 'mcp' pytest --nbmake docs/examples/notebooks/ |
There was a problem hiding this comment.
Please add nbmake to the dev section of the pyproject imports.
Sorry missed this. Let me try and see if its a quick fix or a more long term fix. |
jakelorocco
left a comment
jakelorocco
left a comment
There was a problem hiding this comment.
lgtm assuming tests pass
This PR will hope to fix #286 with some additional inputs from @jakelorocco. For now, it:
conftest.pyqualitative