Quad layer pose in view space and change texture filtering#82
Open
Giulero wants to merge 2 commits intogbionics:mainfrom
Open
Quad layer pose in view space and change texture filtering#82Giulero wants to merge 2 commits intogbionics:mainfrom
Giulero wants to merge 2 commits intogbionics:mainfrom
Conversation
Collaborator
|
Could you do one test with main using only the flag The reason I am asking is because the change in yarp-device-openxrheadset/src/devices/openxrheadset/OpenXrInterface.cpp Lines 1341 to 1366 in f1d265a Hence, I am expecting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When projecting an image in the headset, I noticed a continuous jitter. Some investigations with Claude led to this PR.
So, this PR introduces the following:
--use_native_quad_layers): When using native quad layers, layers are created in VIEW space, where poses are inherently head-relative. The old code multiplied the desired pose by the current head pose on every frame, introducing frame-to-frame jitter from head-tracking noise. The fix skips this multiplication when the layer space is VIEW space.GL_NEARESTtoGL_LINEARin bothImagePortToQuadLayerandOpenGLQuadLayerto avoid pixelation when the image is scaled to the layer size. Also add explicit min/mag filter parameters to the intermediate texture setup.How to test: Run the device with
--use_native_quad_layersand verify that overlays are stable and correctly positioned without jittering.